Skip to content

allowing multiple race values#253

Merged
ericbuckley merged 2 commits into
mainfrom
fix/250-accept-multiple-race-values
Mar 19, 2025
Merged

allowing multiple race values#253
ericbuckley merged 2 commits into
mainfrom
fix/250-accept-multiple-race-values

Conversation

@ericbuckley

@ericbuckley ericbuckley commented Mar 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Allowing for more than 1 race value to be specified per payload. Also fixing a bug in the FHIR parser that only accepted the last race specified, now all race values are processed.

Related Issues

closes #250

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@ericbuckley ericbuckley added the bug Something isn't working label Mar 17, 2025
@ericbuckley ericbuckley self-assigned this Mar 17, 2025
@codecov

codecov Bot commented Mar 17, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.80%. Comparing base (f6cc2d2) to head (68e014e).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #253   +/-   ##
=======================================
  Coverage   97.80%   97.80%           
=======================================
  Files          33       33           
  Lines        1731     1735    +4     
=======================================
+ Hits         1693     1697    +4     
  Misses         38       38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ericbuckley ericbuckley marked this pull request as ready for review March 17, 2025 22:19
m-goggins
m-goggins reviewed Mar 18, 2025
View reviewed changes
Comment thread src/recordlinker/schemas/pii.py
bamader
bamader approved these changes Mar 19, 2025
View reviewed changes

@bamader bamader left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, since we'll be getting the change to FeatureAttribute as part of the kwargs PR.

@ericbuckley ericbuckley merged commit c8a38fd into main Mar 19, 2025
@ericbuckley ericbuckley deleted the fix/250-accept-multiple-race-values branch March 19, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m-goggins m-goggins m-goggins left review comments

@bamader bamader bamader approved these changes

Assignees

@ericbuckley ericbuckley

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Capture additional race info

3 participants

@ericbuckley @bamader @m-goggins