Add endpoint for deleting orphaned persons#221
Merged
Conversation
…ature/163-manage-orphan-data
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #221 +/- ##
==========================================
+ Coverage 97.62% 97.65% +0.03%
==========================================
Files 32 32
Lines 1601 1623 +22
==========================================
+ Hits 1563 1585 +22
Misses 38 38 ☔ View full report in Codecov by Sentry. |
ericbuckley
reviewed
Feb 21, 2025
ericbuckley
reviewed
Feb 21, 2025
ericbuckley
reviewed
Feb 21, 2025
ericbuckley
reviewed
Feb 21, 2025
ericbuckley
previously approved these changes
Feb 21, 2025
ericbuckley
left a comment
Collaborator
There was a problem hiding this comment.
looks good, just a couple of minor suggestions
ericbuckley
approved these changes
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an API endpoint for deleting persons who have no associated patients. It works by checking that the provided person_reference_id is valid and then checking if the person has any associated patients. Persons with associated patients are not deleted.
Related Issues
Addresses 1 of the 3 API endpoints listed in #163
Additional Notes
The other API endpoints in #163 will be in follow-up PRs.