Skip to content

compare the entire GIVEN_NAME#210

Merged
ericbuckley merged 3 commits into
mainfrom
fix/199-concate-given-name
Feb 11, 2025
Merged

compare the entire GIVEN_NAME#210
ericbuckley merged 3 commits into
mainfrom
fix/199-concate-given-name

Conversation

@ericbuckley

@ericbuckley ericbuckley commented Feb 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

When comparing given name values, we should concatenate the entire given name before evaluation. Not doing so runs a risk of obtaining a high score when only the middle names/initials match.

Related Issues

closes #199

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@ericbuckley ericbuckley added the bug Something isn't working label Feb 10, 2025
@ericbuckley ericbuckley self-assigned this Feb 10, 2025
@codecov

codecov Bot commented Feb 10, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.65%. Comparing base (ba4c2ae) to head (24617cb).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
- Coverage   97.65%   97.65%   -0.01%     
==========================================
  Files          32       32              
  Lines        1576     1575       -1     
==========================================
- Hits         1539     1538       -1     
  Misses         37       37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericbuckley ericbuckley marked this pull request as ready for review February 10, 2025 19:56
m-goggins
m-goggins previously approved these changes Feb 10, 2025
View reviewed changes
@ericbuckley ericbuckley merged commit 1af8368 into main Feb 11, 2025
@ericbuckley ericbuckley deleted the fix/199-concate-given-name branch February 11, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m-goggins m-goggins m-goggins approved these changes

@bamader bamader Awaiting requested review from bamader bamader is a code owner

Assignees

@ericbuckley ericbuckley

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

concatenate given name values

2 participants

@ericbuckley @m-goggins