Skip to content

patient / person API endpoints for retrieving data#206

Merged
ericbuckley merged 5 commits into
mainfrom
feature/162-retrieve-cluster-info
Feb 11, 2025
Merged

patient / person API endpoints for retrieving data#206
ericbuckley merged 5 commits into
mainfrom
feature/162-retrieve-cluster-info

Conversation

@ericbuckley

@ericbuckley ericbuckley commented Feb 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Creating GET /person/<ref-id> and GET /patient/<ref-id> to retrieve info on the existing MPI data elements.

Related Issues

closes #162

Additional Notes

Adding a testing helper context manager to count database queries, hoping this can be useful when we want to make assertions on how many SQL queries are issued.

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@ericbuckley ericbuckley added the api New API feature label Feb 8, 2025
@ericbuckley ericbuckley self-assigned this Feb 8, 2025
@codecov

codecov Bot commented Feb 8, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.68%. Comparing base (079bab7) to head (0401ab2).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
+ Coverage   97.65%   97.68%   +0.03%     
==========================================
  Files          32       32              
  Lines        1576     1599      +23     
==========================================
+ Hits         1539     1562      +23     
  Misses         37       37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericbuckley ericbuckley marked this pull request as ready for review February 8, 2025 01:02
m-goggins
m-goggins reviewed Feb 10, 2025
View reviewed changes
Comment thread src/recordlinker/routes/person_router.py
@m-goggins m-goggins self-requested a review February 11, 2025 18:51
bamader
bamader approved these changes Feb 11, 2025
View reviewed changes

@bamader bamader left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ericbuckley ericbuckley merged commit 3f18299 into main Feb 11, 2025
@ericbuckley ericbuckley deleted the feature/162-retrieve-cluster-info branch February 11, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bamader bamader bamader approved these changes

@m-goggins m-goggins m-goggins approved these changes

Assignees

@ericbuckley ericbuckley

Labels

api New API feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

API endpoints for retrieving cluster information [MPIAPI]

3 participants

@ericbuckley @bamader @m-goggins