Appropriately handle race unknown#196
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #196 +/- ##
=======================================
Coverage 97.65% 97.65%
=======================================
Files 32 32
Lines 1576 1576
=======================================
Hits 1539 1539
Misses 37 37 ☔ View full report in Codecov by Sentry. |
ericbuckley
requested changes
Feb 6, 2025
ericbuckley
left a comment
Collaborator
There was a problem hiding this comment.
@bamader would you mind adding another test or two for this, the existing test doesn't account for ASKED_UNKNOWN. It also be good to assert that the other races are still being used appropriately.
Collaborator
Author
|
@ericbuckley No problem, some test cases added to test for other races as well as ASKED_UNKNOWN |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
feature_iteryield for theRACEfield whenever an incoming record has a value for that field ofUNKNOWNorASKED_UNKNOWN. This ensures that, downstream, we don't perform fuzzy string comparisons against known race values andUNKNOWNand thereby award some log odds points where none should be.Related Issues
#193
Additional Notes
n/a
<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: