Skip to content

correct 508 issues on site docs#194

Merged
ericbuckley merged 2 commits into
mainfrom
fix/site-doc-508-issues
Feb 6, 2025
Merged

correct 508 issues on site docs#194
ericbuckley merged 2 commits into
mainfrom
fix/site-doc-508-issues

Conversation

@ericbuckley

@ericbuckley ericbuckley commented Feb 6, 2025

Copy link
Copy Markdown
Collaborator

Description

Making small CSS changes to account for 508 issues axe flagged on the site docs. Note: this does not account for any issues on the API docs.

Notes

The syntax highlighting in the code blocks can cause readability issues due to poor contrast. One way to correct for this is to remove the syntax highlighting (just mark every code block as plaintext).

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@ericbuckley ericbuckley added the bug Something isn't working label Feb 6, 2025
@ericbuckley ericbuckley self-assigned this Feb 6, 2025
@codecov

codecov Bot commented Feb 6, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.59%. Comparing base (8ea5fda) to head (b8db9bd).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #194   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files          31       31           
  Lines        1541     1541           
=======================================
  Hits         1504     1504           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericbuckley ericbuckley marked this pull request as ready for review February 6, 2025 02:06

@m-goggins m-goggins left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ericbuckley ericbuckley added a11y Making digital accessibility easier and removed bug Something isn't working labels Feb 6, 2025
@ericbuckley ericbuckley merged commit b2e692f into main Feb 6, 2025
@ericbuckley ericbuckley deleted the fix/site-doc-508-issues branch February 6, 2025 16:25
@ericbuckley ericbuckley added this to the v25.2.0 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y Making digital accessibility easier

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants