Build msodbc drivers into arm64 images#190
Merged
m-goggins merged 3 commits intoFeb 4, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #190 +/- ##
==========================================
+ Coverage 97.51% 97.59% +0.08%
==========================================
Files 31 31
Lines 1486 1541 +55
==========================================
+ Hits 1449 1504 +55
Misses 37 37 ☔ View full report in Codecov by Sentry. |
ericbuckley
reviewed
Feb 4, 2025
ericbuckley
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
msodbc18 can now be installed on ARM64 (eg Mac M1) platforms so we can remove the if block in the Dockerfile to exclude this process for those platforms.
Related Issues
#184
Additional Notes
I'm not sure if we have a good way to test the success of this change but if I followed the Teams conversation correctly, we have confirmed that NBS was able to get this working.