Skip to content

removing Sex.UNKNOWN [Executive Order 14168]#186

Merged
ericbuckley merged 2 commits into
mainfrom
feature/remove-sex-unknown
Jan 31, 2025
Merged

removing Sex.UNKNOWN [Executive Order 14168]#186
ericbuckley merged 2 commits into
mainfrom
feature/remove-sex-unknown

Conversation

@ericbuckley

@ericbuckley ericbuckley commented Jan 31, 2025

Copy link
Copy Markdown
Collaborator

Description

Removing the Sex.UNKNOWN value per Executive Order 14168.

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@ericbuckley
removing Sex.UNKNOWN
9bd5dae 
removed to be in compliance with Executive Order 14168
@ericbuckley ericbuckley added the api New API feature label Jan 31, 2025
@ericbuckley ericbuckley self-assigned this Jan 31, 2025
@codecov

codecov Bot commented Jan 31, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.51%. Comparing base (9942907) to head (43d36d0).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
- Coverage   97.51%   97.51%   -0.01%     
==========================================
  Files          31       31              
  Lines        1487     1486       -1     
==========================================
- Hits         1450     1449       -1     
  Misses         37       37

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericbuckley ericbuckley marked this pull request as ready for review January 31, 2025 21:30
@ericbuckley ericbuckley merged commit d76f725 into main Jan 31, 2025
@ericbuckley ericbuckley deleted the feature/remove-sex-unknown branch January 31, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bamader bamader Awaiting requested review from bamader bamader is a code owner

@m-goggins m-goggins Awaiting requested review from m-goggins m-goggins is a code owner

Assignees

@ericbuckley ericbuckley

Labels

api New API feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ericbuckley