Patient Details Endpoints#174
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
==========================================
+ Coverage 97.51% 97.59% +0.08%
==========================================
Files 31 31
Lines 1486 1541 +55
==========================================
+ Hits 1449 1504 +55
Misses 37 37 ☔ View full report in Codecov by Sentry. |
…at/patient-details-endpoint
m-goggins
reviewed
Feb 3, 2025
m-goggins
left a comment
Collaborator
There was a problem hiding this comment.
@ericbuckley Looks pretty good to me, though I think some of the docstrings and error messages could potentially be improved to make the new functionality clearer to users. It seems like the error messages in the codebase are fairly minimal so I'm not sure if that was a decision the team previously made. I tend to err on the side of more descriptive errors.
Co-authored-by: Marcelle <53578688+m-goggins@users.noreply.github.com>
Co-authored-by: Marcelle <53578688+m-goggins@users.noreply.github.com>
m-goggins
approved these changes
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add two new API endpoints that allow users to directly add/update patient record details in the MPI.
Related Issues
closes #159
Additional Notes
POST /patient -d '{"record": "...", "person": "person_reference_id"}'Add the above endpoint to allow users to directly add a patient record to the MPI, skipping the record linkage algorithm.
PATCH /patient/<patient-reference-id> -d '{"record": "...", "person": "person_reference_id"}'Add the above endpoint to allow users to update an existing patient record in the MPI.
NOTE: For this operation, the
recordandpersonattributes are optional. If not specified, the existing value will stay unchanged. However, at least 1 must be specified.<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: