Skip to content

style(matchers): rename matchers funcs for clarity#137

Merged
alhayward merged 4 commits into
mainfrom
style/rename-matchers
Nov 27, 2024
Merged

style(matchers): rename matchers funcs for clarity#137
alhayward merged 4 commits into
mainfrom
style/rename-matchers

Conversation

@alhayward

@alhayward alhayward commented Nov 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  • Rename feature matching and evaluation functions for clarity

    Feature Matching

    • feature_match_any -> compare_match_any
    • feature_match_exact -> compare_match_all
    • feature_match_fuzzy_string -> compare_fuzzy_match
    • feature_match_log_odds_fuzzy_compare -> compare_probabilistic_fuzzy_match

    Evaluation

    • eval_perfect_match -> rule_match
    • eval_log_odds_cutoff -> rule_probabilistic_match

Related Issues

closes #109

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@codecov

codecov Bot commented Nov 19, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.43%. Comparing base (3182485) to head (396dc4f).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   95.47%   96.43%   +0.95%     
==========================================
  Files          31       30       -1     
  Lines        1414     1317      -97     
==========================================
- Hits         1350     1270      -80     
+ Misses         64       47      -17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alhayward alhayward marked this pull request as ready for review November 19, 2024 23:35
ericbuckley
ericbuckley reviewed Nov 20, 2024
View reviewed changes
Comment thread docs/site/reference.md Outdated
ericbuckley
ericbuckley reviewed Nov 20, 2024
View reviewed changes
Comment thread src/recordlinker/linking/old_matchers.py
cbrinson-rise8
cbrinson-rise8 reviewed Nov 22, 2024
View reviewed changes
Comment thread docs/site/reference.md Outdated
alhayward and others added 2 commits November 26, 2024 16:12
@alhayward @cbrinson-rise8
Update docs/site/reference.md
81d735d 
Co-authored-by: cbrinson-rise8 <127439654+cbrinson-rise8@users.noreply.github.com>
@alhayward
style(matchers): add prefixes
396dc4f
@alhayward alhayward mentioned this pull request Nov 27, 2024
Merged
9 tasks
@cbrinson-rise8

cbrinson-rise8 commented Nov 27, 2024

Copy link
Copy Markdown
Contributor

Looks great!

@alhayward alhayward merged commit e15af3e into main Nov 27, 2024
@alhayward alhayward deleted the style/rename-matchers branch November 27, 2024 16:21
@ericbuckley ericbuckley mentioned this pull request Feb 11, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericbuckley ericbuckley ericbuckley left review comments

+1 more reviewer

@cbrinson-rise8 cbrinson-rise8 cbrinson-rise8 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adjust matching function names to better represent functionality

3 participants

@alhayward @cbrinson-rise8 @ericbuckley