Skip to content

Dockerfile Smoke Tests#116

Merged
cbrinson-rise8 merged 2 commits into
mainfrom
feat/dockerfile-smoke-tests
Nov 8, 2024
Merged

Dockerfile Smoke Tests#116
cbrinson-rise8 merged 2 commits into
mainfrom
feat/dockerfile-smoke-tests

Conversation

@cbrinson-rise8

@cbrinson-rise8 cbrinson-rise8 commented Nov 4, 2024

Copy link
Copy Markdown
Contributor

Description

Create a new CI workflow that runs a smoke test job when a PR is open.

Related Issues

closes #103

Additional Notes

The smoke test should roughly do the following, but more steps can be added if identified during the development process

  • start up a database
  • build the Dockerfile
  • run the RL service on the docker container
  • send a series (~4 or so) of curl requests to the /link endpoint, and verify results

<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->

Checklist

Please review and complete the following checklist before submitting your pull request:

  • I have ensured that the pull request is of a manageable size, allowing it to be reviewed within a single session.
  • I have reviewed my changes to ensure they are clear, concise, and well-documented.
  • I have updated the documentation, if applicable.
  • I have added or updated test cases to cover my changes, if applicable.
  • I have minimized the number of reviewers to include only those essential for the review.

Checklist for Reviewers

Please review and complete the following checklist during the review process:

  • The code follows best practices and conventions.
  • The changes implement the desired functionality or fix the reported issue.
  • The tests cover the new changes and pass successfully.
  • Any potential edge cases or error scenarios have been considered.

@codecov

codecov Bot commented Nov 4, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.28%. Comparing base (692c193) to head (77a609e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #116   +/-   ##
=======================================
  Coverage   95.28%   95.28%           
=======================================
  Files          29       29           
  Lines        1293     1293           
=======================================
  Hits         1232     1232           
  Misses         61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbrinson-rise8 cbrinson-rise8 self-assigned this Nov 4, 2024
@cbrinson-rise8 cbrinson-rise8 added api New API feature automation Automation of processes labels Nov 4, 2024
@cbrinson-rise8 cbrinson-rise8 force-pushed the feat/dockerfile-smoke-tests branch 2 times, most recently from 7d563fd to 89e7de0 Compare November 4, 2024 18:19
@cbrinson-rise8 cbrinson-rise8 marked this pull request as ready for review November 5, 2024 18:16
Comment thread .github/workflows/check_smoke_tests.yml Outdated
Comment thread .github/workflows/check_smoke_tests.yml Outdated
Comment thread .github/workflows/check_smoke_tests.yml Outdated
Comment thread src/recordlinker/linking/algorithm_service.py
@cbrinson-rise8 cbrinson-rise8 force-pushed the feat/dockerfile-smoke-tests branch from ea9a8fb to fd682bb Compare November 8, 2024 14:32
@cbrinson-rise8 cbrinson-rise8 force-pushed the feat/dockerfile-smoke-tests branch from fd682bb to 2f3b438 Compare November 8, 2024 14:36

@ericbuckley ericbuckley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbrinson-rise8 this is great, thanks so much for working on this, I think its going to help us catch some future bugs early!

@cbrinson-rise8 cbrinson-rise8 merged commit 6340323 into main Nov 8, 2024
@cbrinson-rise8 cbrinson-rise8 deleted the feat/dockerfile-smoke-tests branch November 8, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api New API feature automation Automation of processes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dockerfile smoke tests

2 participants