Dockerfile Smoke Tests#116
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
=======================================
Coverage 95.28% 95.28%
=======================================
Files 29 29
Lines 1293 1293
=======================================
Hits 1232 1232
Misses 61 61 ☔ View full report in Codecov by Sentry. |
7d563fd to
89e7de0
Compare
ericbuckley
reviewed
Nov 5, 2024
ericbuckley
reviewed
Nov 5, 2024
ericbuckley
reviewed
Nov 6, 2024
ericbuckley
reviewed
Nov 7, 2024
ea9a8fb to
fd682bb
Compare
fd682bb to
2f3b438
Compare
ericbuckley
approved these changes
Nov 8, 2024
ericbuckley
left a comment
Collaborator
There was a problem hiding this comment.
@cbrinson-rise8 this is great, thanks so much for working on this, I think its going to help us catch some future bugs early!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Create a new CI workflow that runs a smoke test job when a PR is open.
Related Issues
closes #103
Additional Notes
The smoke test should roughly do the following, but more steps can be added if identified during the development process
<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: