Skip to content

swap models.Algorithm for schemas.Algorithm in linkage #294

@ericbuckley

Description

@ericbuckley

Summary

Pass a schema.Algorithm object to the link method rather than models.Algorithm

Details / Tasks

Theres a one way relationship between schemas and models, the former knows about the latter, but not the other way around (necessary to prevent circular imports). This has created some problems when passing models.Algorithm around in the linkage code, for instance we always have to convert a blocking key id/string to a BlockingKey object for evaluation, same goes for Feature. The schemas class has everything we need for parsing the data into the appropriate objects for evaluation, it made a lot of sense and reduced some of the logic needed in recordlinker/linking by making this switch.

Metadata

Metadata

Assignees

Labels

apiNew API feature

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions