Skip to content

Settings - Fix setting showing up in unicode subcategories#1779

Merged
PabstMirror merged 1 commit intomasterfrom
fixUnicodeSort
Jun 29, 2025
Merged

Settings - Fix setting showing up in unicode subcategories#1779
PabstMirror merged 1 commit intomasterfrom
fixUnicodeSort

Conversation

@PabstMirror
Copy link
Copy Markdown
Contributor

@PabstMirror PabstMirror commented Jun 29, 2025

Before fix (Setting C1 showed up under a subcategory, instead of at the top by itself)
image

due to sort putting unicode above empty string

x = [["n", 1], ["й", 2], ["", 3]];
x sort true
[["й",2],["",3],["n",1]]

@PabstMirror PabstMirror added this to the 3.18.4 milestone Jun 29, 2025
veteran29
veteran29 approved these changes Jun 29, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@veteran29 veteran29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PabstMirror PabstMirror merged commit 5f5efdc into master Jun 29, 2025
4 checks passed
@PabstMirror PabstMirror deleted the fixUnicodeSort branch June 29, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@veteran29 veteran29 veteran29 approved these changes

Assignees

No one assigned

Labels

Bug Fix

Projects

None yet

Milestone

3.18.4

Development

Successfully merging this pull request may close these issues.

2 participants

@PabstMirror @veteran29