Update scope check from 2 to 1 on magazine add/remove functions#1734
Merged
PabstMirror merged 1 commit intoCBATeam:masterfrom Feb 28, 2025
Merged
Update scope check from 2 to 1 on magazine add/remove functions#1734PabstMirror merged 1 commit intoCBATeam:masterfrom
PabstMirror merged 1 commit intoCBATeam:masterfrom
Conversation
PabstMirror
approved these changes
Feb 26, 2025
Contributor
PabstMirror
left a comment
There was a problem hiding this comment.
seems reasonable to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Some functions do a scope < 2 check instead of a scope < 1 check. This will hinder certain magazine items, which aren't accessible in Virtual Arsenal but in the game, to not properly removed from inventories.