Skip to content

Add Missing DIK codes to _supportedKeys in XEH_preStart.sqf#1721

Merged
PabstMirror merged 2 commits intoCBATeam:masterfrom
Raven3-14:patch-1
Jun 17, 2025
Merged

Add Missing DIK codes to _supportedKeys in XEH_preStart.sqf#1721
PabstMirror merged 2 commits intoCBATeam:masterfrom
Raven3-14:patch-1

Conversation

@Raven3-14
Copy link
Copy Markdown
Contributor

@Raven3-14 Raven3-14 commented Nov 30, 2024

Added missing DIK codes to _supportedKeys

When merged this pull request will:

  • Add DIK codes "DIK_F16" through to "DIK_F24" to _supportedKeys, allowing them to be displayed as the correct key in CBA keybindings, rather than "Unknown Key ***"

This will make it match the code in perf/prof branch, and should fix the "Unknown Key ***" for F16~F24 when perf/prof is loaded.
I don't think the vanilla fix has been patched to stable. The relevant ticket in the BI feedback tracker has a note "Fixed in 2.20".

@Raven3-14
Update DIK codes XEH_preStart.sqf
13ac2eb 
Added missing DIK codes to _supportedKeys
@PabstMirror PabstMirror added this to the 3.18.2 milestone Jan 8, 2025
@PabstMirror PabstMirror modified the milestones: 3.18.2, Ongoing Jan 8, 2025
@PabstMirror
Copy link
Copy Markdown
Contributor

PabstMirror commented Feb 14, 2025 •
edited
Loading

just noting that we do need to wait for 2.20 or we get

20:08:48 [CBA] (settings) INFO: Finished reading settings from settings file.
20:08:48 Error in expression <EachPair;
} else {
[_hash, {
_namespace setVariable [_key, _value];
}] call CBA_>
20:08:48   Error position: <setVariable [_key, _value];
}] call CBA_>
20:08:48   Error Reserved variable in expression

on non-profiling w/ filepatching

and because this file is compiled to sqfc the macros won't be defined until we update the includes

@PabstMirror PabstMirror modified the milestones: Ongoing, 3.18.4 Jun 17, 2025
@PabstMirror
Copy link
Copy Markdown
Contributor

PabstMirror commented Jun 17, 2025

from what I can tell BIS never updated the dik codes in the include
so I'm still getting that script error and

diag_log text format ["DIK_F22 is %1", DIK_F22];
10:16:55 DIK_F22 is any

@PabstMirror PabstMirror modified the milestones: 3.18.4, Ongoing Jun 17, 2025
@PabstMirror PabstMirror modified the milestones: Ongoing, 3.18.4 Jun 17, 2025
@PabstMirror
Copy link
Copy Markdown
Contributor

PabstMirror commented Jun 17, 2025

As far as I can tell we are ok to manually define them based on https://feedback.bistudio.com/T125049
I do not have a keyboard with these keys so I will need someone to test this

@PabstMirror PabstMirror merged commit 8c97d73 into CBATeam:master Jun 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees

No one assigned

Labels

2.20 Enhancement

Projects

None yet

Milestone

3.18.4

Development

Successfully merging this pull request may close these issues.

2 participants

@Raven3-14 @PabstMirror