Extended Loadout Framework#1503
Merged
PabstMirror merged 12 commits intoCBATeam:masterfrom May 17, 2022
Merged
Conversation
Contributor
|
Very clean code. Why do we need the whole LoadoutSet framework though? Couldn't we just raise and listen to "vanilla" CBA events? |
Contributor
Author
|
We'd still need to store the defaults for those somewhere, and I don't see any advantage of events over a dedicated function |
commy2
reviewed
Sep 24, 2021
Contributor
Maybe make it a wrapper that uses CBA events? I would really like to avoid duplicating the events logic yet again. |
mharis001
reviewed
Sep 24, 2021
Closed
Contributor
Author
|
Any updates on this? |
Contributor
Author
|
Anyone want to take on modifying this to commy's requirements? I do not have the time. |
Contributor
Author
|
@commy2 Updated as discussed on Slack |
PabstMirror
reviewed
May 13, 2022
PabstMirror
reviewed
May 13, 2022
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
PabstMirror
reviewed
May 14, 2022
mharis001
reviewed
May 14, 2022
PabstMirror
approved these changes
May 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
ACE Earplugs Example
ACRE Flagged Radio example
Usage is very similar to the vanilla
getUnitLoadoutwhen applied to units