Skip to content

Add rfc5280::unknown-critical-extension-unrelated-root#585

Merged
woodruffw merged 2 commits into
mainfrom
ww/unrelated-root-crit
Apr 9, 2026
Merged

Add rfc5280::unknown-critical-extension-unrelated-root#585
woodruffw merged 2 commits into
mainfrom
ww/unrelated-root-crit

Conversation

@woodruffw

Copy link
Copy Markdown
Collaborator

Validators should not fail to construct a chain here, since the only invalid member of the graph should not be used.

Signed-off-by: William Woodruff <william@yossarian.net>
@woodruffw woodruffw self-assigned this Apr 9, 2026
Signed-off-by: William Woodruff <william@yossarian.net>
@github-actions

github-actions Bot commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

:shipit: No regressions found.

@github-actions

github-actions Bot commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

New testcases

There are new testcases in this change.

pyca-cryptography-46.0.7

Testcase Expected Result Actual Result Context
rfc5280::unknown-critical-extension-unrelated-intermediate SUCCESS SUCCESS chain built successfully
rfc5280::unknown-critical-extension-unrelated-root SUCCESS SUCCESS chain built successfully

openssl-3.0.20

Testcase Expected Result Actual Result Context
rfc5280::unknown-critical-extension-unrelated-intermediate SUCCESS SUCCESS None
rfc5280::unknown-critical-extension-unrelated-root SUCCESS SUCCESS None

openssl-3.6.2

Testcase Expected Result Actual Result Context
rfc5280::unknown-critical-extension-unrelated-intermediate SUCCESS SUCCESS None
rfc5280::unknown-critical-extension-unrelated-root SUCCESS SUCCESS None

openssl-1.1

Testcase Expected Result Actual Result Context
rfc5280::unknown-critical-extension-unrelated-intermediate SUCCESS SUCCESS None
rfc5280::unknown-critical-extension-unrelated-root SUCCESS SUCCESS None

gocryptox509-go1.26.2

Testcase Expected Result Actual Result Context
rfc5280::unknown-critical-extension-unrelated-intermediate SUCCESS SUCCESS
rfc5280::unknown-critical-extension-unrelated-root SUCCESS SUCCESS

openssl-3.2.6

Testcase Expected Result Actual Result Context
rfc5280::unknown-critical-extension-unrelated-intermediate SUCCESS SUCCESS None
rfc5280::unknown-critical-extension-unrelated-root SUCCESS SUCCESS None

rust-webpki

Testcase Expected Result Actual Result Context
rfc5280::unknown-critical-extension-unrelated-intermediate SUCCESS SUCCESS None
rfc5280::unknown-critical-extension-unrelated-root SUCCESS FAILURE trusted certs: trust anchor extraction failed

openssl-3.3.7

Testcase Expected Result Actual Result Context
rfc5280::unknown-critical-extension-unrelated-intermediate SUCCESS SUCCESS None
rfc5280::unknown-critical-extension-unrelated-root SUCCESS SUCCESS None

certvalidator-0.11.1

Testcase Expected Result Actual Result Context
rfc5280::unknown-critical-extension-unrelated-intermediate SUCCESS SUCCESS None
rfc5280::unknown-critical-extension-unrelated-root SUCCESS SUCCESS None

gnutls-certtool-3.8.3

Testcase Expected Result Actual Result Context
rfc5280::unknown-critical-extension-unrelated-intermediate SUCCESS SUCCESS Chain verification output: Verified. The certificate is trusted.
rfc5280::unknown-critical-extension-unrelated-root SUCCESS SUCCESS Chain verification output: Verified. The certificate is trusted.

openssl-3.5.6

Testcase Expected Result Actual Result Context
rfc5280::unknown-critical-extension-unrelated-intermediate SUCCESS SUCCESS None
rfc5280::unknown-critical-extension-unrelated-root SUCCESS SUCCESS None

rustls-webpki

Testcase Expected Result Actual Result Context
rfc5280::unknown-critical-extension-unrelated-intermediate SUCCESS SUCCESS None
rfc5280::unknown-critical-extension-unrelated-root SUCCESS FAILURE trusted certs: trust anchor extraction failed

openssl-3.4.5

Testcase Expected Result Actual Result Context
rfc5280::unknown-critical-extension-unrelated-intermediate SUCCESS SUCCESS None
rfc5280::unknown-critical-extension-unrelated-root SUCCESS SUCCESS None

@woodruffw

Copy link
Copy Markdown
Collaborator Author
image

@woodruffw woodruffw merged commit 204ca14 into main Apr 9, 2026
9 checks passed
@woodruffw woodruffw deleted the ww/unrelated-root-crit branch April 9, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant