Merged
Conversation
d12107a to
feb6c57
Compare
Contributor
|
The mypy issue is due to a recent change in termcolor from this PR: termcolor/termcolor#97 |
Collaborator
Author
|
Yes we can, just tried to respect what the person did by introducing this import of Color. This way you still document that this is a Color type (even though a color type is just str). Whatever you want, I will do it, I just want to merge this. |
agoscinski
commented
May 6, 2025
agoscinski
commented
May 6, 2025
Replace the `Color` type by `str` as it does not exist in termcolor. The mypy issue is due to a recent change in termcolor from the PR termcolor/termcolor#97
c40bb1f to
096da1d
Compare
leclairm
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See error in CI of other PRs that do not change any code https://github.com/C2SM/Sirocco/actions/runs/14636678151/job/41069300388
It does not make sense to enforcing typing for it if termcolor does not support it https://github.com/termcolor/termcolor/blob/fd08149187df889da631805ab3651e9265eb8f00/src/termcolor/termcolor.py#L130C12-L130C15 I made a TypeAlias. I think this was a bug always but was not detected till som mypy update.