Merged
Conversation
* Move definitions of functions in tf_help to separate src cpp file to avoid multiple definition error * Fix linting issues * Make uncrustify happier * More format fixing
Signed-off-by: Marwan Taher <marokhaled99@gmail.com>
* prototype of lifecycle bond system * adding more structure to get around weak ptr issue * working prototype for manager * adding some ns -> s conversions * changing to service node * adding bond connections to all servers * update logs * fixing review comments * fix types * remove extraneous functions * make linters happy * simplifications * adding spinner to get working but now unstable * moving bond connections to activate state * adding defaults * working complete prototype for review * update dependencies * adding connection logging * remove accidental file * fix server side timeout for heartbeats * adding complete unit coverage of bond support * fixing lifecycle test * trying to activate since autostart was removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Future work that may be required in bullet points