feat(aws-vault-proxy): use multi-stage docker builds and static binary#305
feat(aws-vault-proxy): use multi-stage docker builds and static binary#305mbevc1 merged 1 commit intoByteNess:mainfrom
Conversation
|
Thanks for your contribution @gdamjan . Would you mind please fixing PR checks? |
this decreases the image size from ~970MB to ~10MB temporarily removed the healthcheck from docker-compose that expects `pgrep` to be available (it IS meaningless too)
|
oh, does it check the commit or the PR title? |
|
ook. I've temporarily removed the healthcheck from docker-compose that expects I'll create another PR with a better healthcheck. |
|
Yes, there is a conventional commit check set up, thanks |
| healthcheck: | ||
| test: pgrep aws-vault-proxy |
There was a problem hiding this comment.
Can we add something else or leave this still?
There was a problem hiding this comment.
it's a single process docker, it does not make sense to check the process existence. if the process does not exists, the docker container will not exist either.
I'll add a http health check separately.
There was a problem hiding this comment.
and, there's no longer pgrep in the image (if it was not clear)
this decreases the image size from ~970MB to ~10MB