Conversation
|
I was experimenting with this in The Rust Programming Language and discovered that it’s ending up inserting escape characters in places we don’t want. Example: |Example|
|-------|
| `>>` |This ends up being output as: |Example|
|-------|
|`\>>`|This in turn means that if there are multiple passes, e.g. if you have more than one mdBook preprocessor, it ends up repeatedly escaped. 😅 I am looking at the code, but I think the only think that actually needs to be escaped like this in inline code within a table is a pipe? |
9782ab7 to
37e8dcb
Compare
|
I updated the implementation per my comment above; it now only escapes |
Byron
left a comment
There was a problem hiding this comment.
Thanks a lot for tackling this, good work!
There are some minor improvements that I think should be made before merging, centred around clarity and performance.
Thanks again.
Co-authored-by: Sebastian Thiel <sebastian.thiel@icloud.com>
Byron
left a comment
There was a problem hiding this comment.
Great, that does it, thanks again!
Unfortunately I forgot to mention that the Make State struct non-exhaustive commit should rather be named fix!: <the subject as before> to instruct the release tool that this is a breaking change.
I will do the rewrites myself before merging.
That way, future additions to the rather internal state won't be a reason for breaking changes anymore.
586341d to
a85fe39
Compare
|
And here is the new release: https://github.com/Byron/pulldown-cmark-to-cmark/releases/tag/v19.0.0. |
|
Ah, excellent – thank you! Will double check commit message formatting going forward if/as I contribute here. Much obliged for the quick turnaround! |
Fixes #89. Let me know if you’d like me to approach any part of this in a different way!