fix(windows): use SHOpenFolderAndSelectItems for folders to respect expand to open folder setting fixes #103#104
Conversation
Byron
left a comment
There was a problem hiding this comment.
Thanks a lot for the fix!
I think the commit message needs to be revised though. Releases for me get easier with a fix: prefix, probably followed by the (#103) suffix. The subject would be a one-line reason for the change, followed by the exhaustive explanation in the body.
Without it, I am sure somebody else would come along and revert it because they preferred the previous behaviour.
I think the gist of the long explainer - the way I understood it - is that this form of opening the directory will respect a setting in the explorer that affects if the folder is selected in the sidebar as well. Without it, it will always select the folder.
Thank you.
SHOpenFolderAndSelectItems for folders to respect expand to open folder setting fixes #103
|
Changed the title, don't know if it's too long though, feel free to change it |
|
I am talking about the commit, which also needs a body. I want to avoid to rewrite verified commits. |
f454cb2 to
5951fa6
Compare
|
Ah, I was thinking about squash merge, force pushed the previous commit |
5951fa6 to
02cee81
Compare
To respect 'expand to open folder' setting Fixes Byron#103
02cee81 to
7595da7
Compare
|
That will do, thanks! Here is the new release: https://github.com/Byron/open-rs/releases/tag/v5.3.1 |
Use
SHOpenFolderAndSelectItemsinstead ofShellExecuteExWfor folders on WindowsFix #103