fix: deprecate that_in_background() as that() is definitely non-blocking now.

Byron · Byron · commit df358d296fc4 · 2022-06-12T09:32:01.000+08:00
Note that we keep `with_in_background()` as it's unclear if a custom
launcher blocks or not.
diff --git a/src/lib.rs b/src/lib.rs
@@ -119,16 +119,18 @@ pub fn with<T: AsRef<OsStr>>(path: T, app: impl Into<String>) -> io::Result<()>
     os::with(path, app)
 }
 
-/// Open path with the default application in a new thread, which is useful if
-/// the program ends up to be blocking. Otherwise, prefer [`that()`].
+/// Open path with the default application in a new thread.
 ///
 /// See documentation of [`that()`] for more details.
+#[deprecated = "Use `that()` as it is non-blocking while making error handling easy."]
 pub fn that_in_background<T: AsRef<OsStr>>(path: T) -> thread::JoinHandle<io::Result<()>> {
     let path = path.as_ref().to_os_string();
     thread::spawn(|| that(path))
 }
 
-/// Open path with the given application in a new thread.
+/// Open path with the given application in a new thread, which is useful if
+/// the program ends up to be blocking. Otherwise, prefer [`with()`] for
+/// straightforward error handling.
 ///
 /// See documentation of [`with()`] for more details.
 pub fn with_in_background<T: AsRef<OsStr>>(
