printer: finish removal of max_matches#3166
Merged
BurntSushi merged 1 commit intomasterfrom Oct 4, 2025
Merged
Conversation
This finishes what I started in commit a6e0be3. Specifically, the `max_matches` configuration has been moved to the `grep-searcher` crate and *removed* from the `grep-printer` crate. The commit message has the details for why we're doing this, but the short story is to fix #3076. Note that this is a breaking change for `grep-printer`, so this will require a semver incompatible release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This finishes what I started in commit
a6e0be3.
Specifically, the
max_matchesconfiguration has been moved to thegrep-searchercrate and removed from thegrep-printercrate. Thecommit message has the details for why we're doing this, but the short
story is to fix #3076 without other regressions.
Note that this is a breaking change for
grep-printer, so this willrequire a semver incompatible release.