core/state: Add some state metrics#504
Merged
tungng98 merged 2 commits intoBuildOnViction:pre-releasefrom Feb 17, 2025
Merged
Conversation
tungng98
approved these changes
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates to the
core/stateandtomox/tradingstatepackages, focusing on enhancing theCommitmethod to return an additional integer value representing the number of committed nodes. Additionally, it includes various code refactorings and improvements to metrics tracking.Updates to
core/statepackage:Commitmethod: Modified theCommitmethod in multiple files to return an additional integer value indicating the number of committed nodes. (core/state/database.go,core/state/state_object.go,core/state/statedb.go,light/postprocess.go,light/trie.go) [1] [2] [3] Ff568cf3L175R175, [4]core/state/metrics.go,core/state/state_object.go,core/state/statedb.go) [1] [2] [3]Updates to
tomox/tradingstatepackage:Commitmethod: Updated theCommitmethod across various files to return an additional integer value for the number of committed nodes. (tomox/tradingstate/database.go,tomox/tradingstate/state_lendingbook.go,tomox/tradingstate/state_liquidationprice.go,tomox/tradingstate/state_orderList.go,tomox/tradingstate/state_orderbook.go,tomox/tradingstate/statedb.go,tomox/tradingstate/tomox_trie.go) [1] [2] [3] [4] [5] [6] [7]tomox/tradingstate/state_lendingbook.go,tomox/tradingstate/state_liquidationprice.go,tomox/tradingstate/state_itemList.go,tomoxlending/lendingstate/state_lendingbook.go) [1] [2] [3] [4]These changes collectively improve the functionality and maintainability of the codebase by providing more detailed commit information and enhancing metrics tracking.
Reference: