fetcher: update block propagate monitoring metrics#502
Merged
tungng98 merged 2 commits intoBuildOnViction:pre-releasefrom Mar 21, 2025
Merged
fetcher: update block propagate monitoring metrics#502tungng98 merged 2 commits intoBuildOnViction:pre-releasefrom
tungng98 merged 2 commits intoBuildOnViction:pre-releasefrom
Conversation
tungng98
approved these changes
Mar 20, 2025
tungng98
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite:
Information
This pull request refactor the names of some metrics in
fetcherfor clarify and easy to visualize on Grafana.Refactoring and Code Clarity metric names:
eth/fetcher/fetcher.go: Renamed several metrics variables for consistency (propAnnounceInMetertoblockAnnounceInMeter,propAnnounceDOSMetertoblockAnnounceDOSMeter, etc.). [1] [2] [3] [4] [5]These changes enhance the observability of the system by providing detailed metrics on various operations, which can help in performance monitoring and debugging.
Reference: