Skip to content

Support eth_getLogs query with blockHash params. #480

Merged
tungng98 merged 1 commit intoBuildOnViction:pre-releasefrom
c98tristan:feat/get-logs-block-hash
Nov 24, 2024
Merged

Support eth_getLogs query with blockHash params. #480
tungng98 merged 1 commit intoBuildOnViction:pre-releasefrom
c98tristan:feat/get-logs-block-hash

Conversation

@c98tristan
Copy link
Copy Markdown
Contributor

This PR support eth_getLogs query with blockHash params. to support query transaction logs.

  1. Derive FilterCriteria from ethereum.FilterQuery
  2. Add BlockHash to FilterCriteria
  3. Unit testing

Reference:

@c98tristan c98tristan changed the base branch from master to pre-release November 22, 2024 08:51
@c98tristan c98tristan marked this pull request as ready for review November 22, 2024 08:52
@tungng98
Copy link
Copy Markdown
Collaborator

Great finding and implementation

@tungng98 tungng98 merged commit 6ea52b8 into BuildOnViction:pre-release Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants