Skip verify header when trace block#476
Merged
tungng98 merged 4 commits intoBuildOnViction:pre-releasefrom Nov 7, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the trace API for block numbers below 3M (TIPSigning), the node returns an invalid penalty list on checkpoint blocks due to the use of the old HookPenalty.
The old HookPenalty uses the latest statedb to calculate the penalty list, which relies on the state of the BlockSigner contract. However, in the latest statedb, the code and data of the BlockSigner contract are removed by TIPSigningBlock:
victionchain/miner/worker.go
Line 623 in a7014d3
Removing the header verification for block < TIPSigning can fix this issue. We will cover trace bad block in future PR