Merged
Conversation
AlexIIL
requested changes
Apr 11, 2020
Member
AlexIIL
left a comment
There was a problem hiding this comment.
Can you change this to use a functional interface instead? That way we get more control over exactly what NBT tags (and subtags) are compared. (Likely with a method of areEqual(ItemStack a, ItemStack b, boolean matchDamage), where matchDamage is for comparing subtypes - for example your ic2 handler would only compare if this was true, as false is used for a fuzzy search (like in the list)).
(Although it's a bit trickier if you want to allow multiple people to register multiple comparators).
4d21f61 to
68db0b0
Compare
AlexIIL
reviewed
Apr 13, 2020
68db0b0 to
00efb55
Compare
Contributor
Author
|
I already have created a branch in BuildCraftCompat with the second part of the fix. I will send a new PR when this PR will be merged. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is a part of the fix. The second part will go to BuildCraftCompat. There will be a registration of NBT keys for ic2 cables.