Upgrade to latest version of socket.io due to security vulnerability#1936
Merged
shakyShane merged 3 commits intoBrowserSync:masterfrom Mar 4, 2022
lachieh:socket-io-upgrade
Merged
Upgrade to latest version of socket.io due to security vulnerability#1936shakyShane merged 3 commits intoBrowserSync:masterfrom lachieh:socket-io-upgrade
shakyShane merged 3 commits intoBrowserSync:masterfrom
lachieh:socket-io-upgrade
Conversation
- switch to ts-loader over deprecated `awesome-typescript-loader` - update invalid window.reload implementations
|
is there any update on when this will be fixed? |
Contributor
Author
|
It's fixed, I'm just waiting on someone from the team to review/approve/merge |
Contributor
|
Thank you so much @lachieh, this is great :) |
Contributor
|
@lachieh this actually breaks connections between server/clients - it's 100% my issue here for not enabling the integration tests in CI, which I'm resolving now |
Contributor
Author
|
@shakyShane thanks for merging! Is there anything I can help with? |
Contributor
|
@lachieh sorry for the delay - this is fixed in I went ahead and bumped socket.io-client to latest also. |
Contributor
Author
|
Awesome, thanks so much for the work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are 4 main things that had to change to support the upgrade to the latest version of socket.io
io.set(): This was deprecated in v2 and removed in v3. It was being used to set the heartbeat timeout, but that setting was also removed in v3 because engine.io reversed the mechanism.connectedproperty of the server tosockets, which is the name chosen internally in browserSync to attach the namespaced socket back to the server instance. This fix probably needs further refactoring, but for the browserSync use case, it works fine.Fixes #1847
Fixes #1850
Fixes #1892
Fixes #1925
Fixes #1926
Fixes #1933