Skip to content

Update VDF Entry with missing fields#2

Merged
heyvito merged 1 commit intomasterfrom
master
Aug 30, 2021
Merged

Update VDF Entry with missing fields#2
heyvito merged 1 commit intomasterfrom
master

Conversation

@BrianLima
Copy link
Owner

Add the appid field and fixes the name of the exe and appname to use the same capitalization as expected by Steam

In the following binary comparison, it is possible to notice that the appid is removed from a file when it is re-serialized, and that the capitalization of some of the fields are changed, this probably interferes with what Steam expects, causing it to re-calculate the appid of an pre-existing shortcut, losing the connection to custom artworks in the library after the re-serialization done by projects using this library.
image

Add the appid field and fixes the name of the exe and appname to use the same capitalization as expected by Steam
@heyvito
Copy link
Collaborator

heyvito commented Aug 30, 2021

Hey @BrianLima would you like me to transfer this repo over to you?

You'd need to keep its license as is, perhaps appending an extra "Copyright" line to it (that line should appear before the one already present) would do the trick in order to maintain MIT compliance.

Copyright (c) 2021 Brian Lima

Let me know in case you are interested, and I can start the transfer process right away.

@BrianLima
Copy link
Owner Author

That would be nice, sorry if the occasional bug fix on sundays is bothering you 😇

@heyvito
Copy link
Collaborator

heyvito commented Aug 30, 2021

Nah, PRs are always welcome. It just makes sense to transfer, specially since I don't intend to touch C# again hehe
You should receive an email in a few minutes.

Thanks!

@heyvito
Copy link
Collaborator

heyvito commented Aug 30, 2021

Uh oh. I'll merge this PR, then you will need to delete your fork.
Let me know once it's done, so I can transfer it. :)

@heyvito heyvito merged commit b8b84c9 into BrianLima:master Aug 30, 2021
@BrianLima
Copy link
Owner Author

@heyvito done and done!

@heyvito
Copy link
Collaborator

heyvito commented Aug 30, 2021

Awesome! Transferring now :)

@heyvito
Copy link
Collaborator

heyvito commented Aug 30, 2021

Yay! Thank you, Brian!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants