Skip to content

sqf: optimize _this call#802

Merged
BrettMayson merged 6 commits intomainfrom
this_call
Oct 18, 2024
Merged

sqf: optimize _this call#802
BrettMayson merged 6 commits intomainfrom
this_call

Conversation

@BrettMayson
Copy link
Copy Markdown
Owner

@BrettMayson BrettMayson commented Oct 18, 2024

  • Optimizes _this call to just call
  • Off by default lint

@BrettMayson BrettMayson merged commit a148b53 into main Oct 18, 2024
@BrettMayson BrettMayson deleted the this_call branch October 18, 2024 02:08
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 69.30693% with 31 lines in your changes missing coverage. Please review.

Project coverage is 68.2%. Comparing base (4d93c00) to head (e33cdc5).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
libs/sqf/src/analyze/lints/s22_this_call.rs 74.1% 24 Missing ⚠️
libs/sqf/src/compiler/optimizer/mod.rs 12.5% 7 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
libs/sqf/src/compiler/optimizer/mod.rs 78.8% <12.5%> (-1.9%) ⬇️
libs/sqf/src/analyze/lints/s22_this_call.rs 74.1% <74.1%> (ø)

severgun
severgun reviewed Oct 18, 2024
View reviewed changes
@PabstMirror PabstMirror mentioned this pull request Oct 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

+1 more reviewer

@severgun severgun severgun left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BrettMayson @severgun @PabstMirror