Skip to content

sqf: Add lint for count being replaceable with findIf#1186

Merged
BrettMayson merged 1 commit intomainfrom
countskip
Jan 31, 2026
Merged

sqf: Add lint for count being replaceable with findIf#1186
BrettMayson merged 1 commit intomainfrom
countskip

Conversation

@PabstMirror
Copy link
Copy Markdown
Collaborator

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 14, 2026

Codecov Report

❌ Patch coverage is 73.73737% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.0%. Comparing base (988263d) to head (bcbac81).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
libs/sqf/src/analyze/lints/s35_count_skipable.rs 73.7% 26 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
libs/sqf/src/analyze/lints/s35_count_skipable.rs 73.7% <73.7%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines +43 to +47
fn default_config(&self) -> LintConfig {
// Disabled by default because `count` could be appropriate in some cases
// e.g. { x setVar y; alive x} count allUnits == 0;
LintConfig::help().with_enabled(LintEnabled::Pedantic)
}
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if the wiki could have which commands have effects or not, so HEMTT could detect this

@BrettMayson BrettMayson merged commit 0e52d60 into main Jan 31, 2026
34 checks passed
@BrettMayson BrettMayson deleted the countskip branch January 31, 2026 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants