Skip to content

sqf: reimplementing command#1131

Merged
BrettMayson merged 3 commits intomainfrom
reimplementing
Nov 20, 2025
Merged

sqf: reimplementing command#1131
BrettMayson merged 3 commits intomainfrom
reimplementing

Conversation

@BrettMayson
Copy link
Copy Markdown
Owner

@BrettMayson BrettMayson commented Nov 20, 2025

image

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 20, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 86.64745% with 139 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.3%. Comparing base (3e200c7) to head (67a7475).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...alyze/lints/s33_reimplementing_command/distance.rs 76.2% 33 Missing ⚠️
...qf/src/analyze/lints/s33_reimplementing_command.rs 67.1% 24 Missing ⚠️
...rc/analyze/lints/s33_reimplementing_command/max.rs 78.1% 24 Missing ⚠️
...rc/analyze/lints/s33_reimplementing_command/min.rs 78.1% 24 Missing ⚠️
libs/sqf/src/compiler/optimizer/mod.rs 0.0% 10 Missing ⚠️
...c/analyze/lints/s33_reimplementing_command/ceil.rs 93.2% 7 Missing ⚠️
...rc/analyze/lints/s33_reimplementing_command/abs.rs 95.5% 4 Missing ⚠️
...ts/s33_reimplementing_command/linear_conversion.rs 95.4% 4 Missing ⚠️
...s/sqf/src/analyze/lints/s07_select_parse_number.rs 60.0% 2 Missing ⚠️
.../analyze/lints/s33_reimplementing_command/clamp.rs 98.4% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
Files with missing lines Coverage Δ
libs/sqf/src/analyze/inspector/commands.rs 84.6% <100.0%> (ø)
libs/sqf/src/analyze/lints/s27_select_count.rs 75.0% <100.0%> (ø)
libs/sqf/src/analyze/lints/s30_configof.rs 73.3% <100.0%> (ø)
...src/analyze/lints/s33_reimplementing_command/pi.rs 100.0% <100.0%> (ø)
libs/sqf/src/analyze/lints/s05_if_assign.rs 73.9% <50.0%> (ø)
.../analyze/lints/s33_reimplementing_command/floor.rs 98.4% <98.4%> (ø)
libs/sqf/src/lib.rs 65.4% <87.5%> (+0.6%) ⬆️
...s/sqf/src/analyze/lints/s07_select_parse_number.rs 68.6% <60.0%> (+0.5%) ⬆️
.../analyze/lints/s33_reimplementing_command/clamp.rs 98.4% <98.4%> (ø)
...analyze/lints/s33_reimplementing_command/modulo.rs 96.8% <96.8%> (ø)
... and 8 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BrettMayson BrettMayson marked this pull request as ready for review November 20, 2025 15:59
@BrettMayson BrettMayson merged commit c21eca7 into main Nov 20, 2025
32 of 34 checks passed
@BrettMayson BrettMayson deleted the reimplementing branch November 20, 2025 16:09
@PabstMirror
Copy link
Copy Markdown
Collaborator

PabstMirror commented Nov 22, 2025

for L-S33-FLOOR
realized it handles negative number differently
r = -2.2;
r - (r % 1) = -2
floor r = -3

@BrettMayson
Copy link
Copy Markdown
Owner Author

BrettMayson commented Nov 22, 2025

:|

@PabstMirror PabstMirror mentioned this pull request Dec 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PabstMirror PabstMirror PabstMirror left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BrettMayson @PabstMirror