BI-2373 Add Delete Option to Germplasm Lists View#420
Conversation
83867c3 to
bca16f2
Compare
mlm483
left a comment
There was a problem hiding this comment.
In addition to my comments, one thing to consider is making the list name a link to the list detail view rather than having a separate "Details" action stacked on top of "Download". I think it would make the UI easier to navigate.
| <h1 class="title"> | ||
| {{ list ? list.listName : "" | toStartCase }} | ||
| {{ toStartCase(list ? list.listName : "") }} | ||
| </h1> |
There was a problem hiding this comment.
Because the system treats list names as case-sensitive for validation purposes, I would not alter the casing for display. For example, I can upload lists called "yhh" and "Yhh", but when I try to upload a third list with the name "Yhh", I get the validation error, "Error: Import group name already exists".
There was a problem hiding this comment.
The edit on line 26 just fixes the old filter syntax that was throwing an error. The filter has the same functionality and list names are still displayed with case sensitivity as in the image, so I don't think there is any change needed here.
There was a problem hiding this comment.
My initial comment may have been unclear, I'm talking about the <h1> on the germplasm by list view. In this screenshot, you can see how the list of lists view shows the case-sensitive names, but the germplasm by list view uses toStartCase. I recommend removing the call to toStartCase on line 26 of GermplasmByList.vue.
There was a problem hiding this comment.
Agreed. I removed the filter.
That's a valid point. I would bring this up at a meeting and at least let @shawnyarnes weigh in since it's a UI change, rather than tacking it on to this feature where the scope doesn't really overlap. |
a9a1add to
3878201
Compare
3878201 to
2bd27e7
Compare
Description
Story: BI-2373
Dependencies
BI-2372 BI-2374
Testing
Checklist: