Skip to content

[BI-2295] - Allow Experimental Collaborators To View Collaborators#397

Merged
HMS17 merged 2 commits intodevelopfrom
feature/BI-2295
Sep 6, 2024
Merged

[BI-2295] - Allow Experimental Collaborators To View Collaborators#397
HMS17 merged 2 commits intodevelopfrom
feature/BI-2295

Conversation

@HMS17
Copy link
Contributor

@HMS17 HMS17 commented Aug 30, 2024

Description

Story: BI-2295 - Allow Experimental Collaborators To View Collaborators

UI Fixes to Enable Experimental Collaborator and Read Only users to see list of collaborators associated with an experiment

  • Changed remove collaborator button to match other buttons in DeltaBreed
  • Adjusted spacing for displayed collaborators on an experiment and placed collaborator email in parentheses
  • Modified remove collaborator button to only display for roles with permissions to manage collaborators
  • Adjusted ability.ts related logic to use "manage" rather than "create" collaborators to better clarify the permission
  • Bolded link in Add Experimental Collaborator modal for accessibility purposes

Dependencies

bi-api: feature/BI-2295

Testing

Create a program with experiments and more than one experimental collaborator
Assign experimental collaborators to the experiment
Ensure experimental collaborators are displayed on the experiment page

  • With the email in parentheses
  • With a delete button next to each one
  • With spacing so the name and email are next to each other

Log in as an experimental collaborator and go to experiment
Ensure experimental collaborators are displayed on the experiment page

  • With the email in parentheses
  • With NO delete buttons
  • With spacing so the name and email are next to each other

Change user to Read Only for the experiment and go to experiment
Ensure experimental collaborators are displayed on the experiment page

  • With the email in parentheses
  • With NO delete buttons
  • With spacing so the name and email are next to each other

Change user to Program Administrator for the experiment and go to experiment
Ensure experimental collaborators are displayed on the experiment page

  • With the email in parentheses
  • With a delete button next to each one
  • With spacing so the name and email are next to each other

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@HMS17 HMS17 merged commit aa15a4d into develop Sep 6, 2024
@HMS17 HMS17 deleted the feature/BI-2295 branch September 6, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants