Skip to content

[BI-1867] - Ontology: Increase name length to 16 characters#354

Merged
HMS17 merged 2 commits intodevelopfrom
feature/BI-1867
Dec 6, 2023
Merged

[BI-1867] - Ontology: Increase name length to 16 characters#354
HMS17 merged 2 commits intodevelopfrom
feature/BI-1867

Conversation

@HMS17
Copy link
Contributor

@HMS17 HMS17 commented Dec 1, 2023

Description

Story: BI-1867 - Ontology: Increase name length to 16 characters

Modified front end logic to increase ontology name length limit from 12 to 16 characters.

Dependencies

bi-api: feature/BI-1867

Testing

In both ontology import and manual entry of ontology:

  • Try to add an ontology term with 16 characters, should succeed and new entry show up in ontology table
  • Try to add an ontology term with 17 characters, confirm that an error message indicating that character limit must be 16 or less shows up and import is blocked and no new terms are added to ontology table

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

Copy link
Contributor

@mlm483 mlm483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.

I noticed that the error message when the name is too long says "Name must be less than 16 characters", which isn't quite right. Might be worth changing L103 in BaseFieldWrapper.vue to say "...must be no longer than..." instead. That could also be a separate change.
Screenshot 2023-12-04 at 12 48 04 PM

Copy link
Contributor

@davedrp davedrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passed developer testing

@HMS17 HMS17 merged commit adb2b12 into develop Dec 6, 2023
@HMS17 HMS17 deleted the feature/BI-1867 branch December 6, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants