BI-1647 (View Experiments: Observation Dataset Table)#322
Merged
Conversation
6 tasks
mlm483
requested changes
Aug 7, 2023
Contributor
mlm483
left a comment
There was a problem hiding this comment.
I left a bunch of comments, it looks good overall.
mlm483
approved these changes
Aug 14, 2023
Contributor
mlm483
left a comment
There was a problem hiding this comment.
One suggested change, looks good.
src/breeding-insight/model/Trial.ts
Outdated
Comment on lines
+44
to
+45
| console.log('xxxxxxxxxxxxxxxxxxxxxxxxxxxxx'); | ||
| console.log(this); |
Contributor
There was a problem hiding this comment.
Suggested change
| console.log('xxxxxxxxxxxxxxxxxxxxxxxxxxxxx'); | |
| console.log(this); |
Member
nickpalladino
left a comment
There was a problem hiding this comment.
Had an issue with a test experiment loading but wasn't able to reproduce with Dave so thinking it's a local issue. Included it here for reference but ok moving forward.
src/breeding-insight/model/Trial.ts
Outdated
Comment on lines
+44
to
+45
| console.log('xxxxxxxxxxxxxxxxxxxxxxxxxxxxx'); | ||
| console.log(this); |
| this.newObservationActive = true; | ||
| } | ||
|
|
||
| // updateObservation(updatedObservation: Observation) { |
Member
There was a problem hiding this comment.
Is this commented out stuff being saved for a future card?
Contributor
Author
There was a problem hiding this comment.
No. I removed the commented code and unused methods.
… will be consistance (re: feedback from demo)
nickpalladino
approved these changes
Aug 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BI-1647 (View Experiments: Observation Dataset Table)
Dependencies
bi-api: branch feature/BI-1647
Testing
Checklist: