[BI-1720] - Export Multiple Environment Datasets as Zip#320
Merged
Conversation
7 tasks
dmeidlin
approved these changes
Jul 19, 2023
timparsons
requested changes
Jul 26, 2023
src/breeding-insight/dao/StudyDAO.ts
Outdated
| export class StudyDAO { | ||
|
|
||
| static async getAllForTrial(programId: string, trialId: string): Promise<Result<Error, BiResponse>> { | ||
| static async getAllForTrial(programId: string, trialDbId: string): Promise<Result<Error, BiResponse>> { |
Member
There was a problem hiding this comment.
I think this should be changed to use the BI ID of the trial, not the trialDbId. This would mean setting the externalReferenceId instead of trialDbId in the request
Contributor
Author
There was a problem hiding this comment.
Done, afb70db. The externalReferenceId and externalReferenceSource are now sent as query parameters instead of trialDbId.
timparsons
approved these changes
Jul 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: https://breedinginsight.atlassian.net/browse/BI-1720
The accompanying PR on bi-api: Breeding-Insight/bi-api#263.
The download modal for experiments now provides a checkbox for each environment in the experiment, in addition to the "All Environments" checkbox. Selecting the "All Environments" checkbox disables the individual environment checkboxes (their checked state is preserved).
If "All Environments" is selected, the
environmentsquery parameter is NOT sent, and all environments are expected in a single file. If one or more individual environment checkboxes are selected (and "All" is unselected), theenvironmentsquery parameter is a comma-separated list of requested environmentIds, and each environment is expected to be in a separate file, zipped if more than one. See table below.environmentsquery param:I also did some cleanup:
TrialsAndStudiesBase, replaced usages withProgramsBasewhich was identical.trialDbIdvs.trialIdin several places.Dependencies
Most of the changes for this feature are in the bi-api feature/BI-1720 branch.
Testing
Checklist: