Feature/bi 1618 - Import File Selection Behavior#319
Merged
Conversation
4 tasks
dmeidlin
approved these changes
Jun 14, 2023
nickpalladino
approved these changes
Jun 16, 2023
Member
nickpalladino
left a comment
There was a problem hiding this comment.
The only thing I noticed in testing was that when an upload fails and you choose a new file the filename will be highlighted red like it is erroneous rather than black for the normal case. Not really a big deal to me so I'll approve either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BI-1618 - Import File Selection Behavior
Dependencies
bi-api: feature/BI-1618
Testing
Import files into Germplasm, Ontology, and Experiments. One file for each type of error:
Checklist: