Skip to content

Feature/bi 1618 - Import File Selection Behavior#319

Merged
davedrp merged 7 commits intodevelopfrom
feature/BI-1618
Jun 30, 2023
Merged

Feature/bi 1618 - Import File Selection Behavior#319
davedrp merged 7 commits intodevelopfrom
feature/BI-1618

Conversation

@davedrp
Copy link
Contributor

@davedrp davedrp commented Jun 12, 2023

Description

BI-1618 - Import File Selection Behavior

  • To satisfy requirement 1 -- the button wording was changed in FileSelectMessageBox.vue
  • To satisfy requirement 2 -- In views/import/ImportTemplate.vue and views/trait/TraitsImport.vue the ImportAction.RESET is called to set this.file to null.
  • To satisfy requirement 3 -- All import errors will now result in an error-banner on the top of the page (If the error-banner was appearing before this release, it will still appear, but with the improved verbiage. If there was no error-banner before this release, now it will now appear, as well as the errors as they were previously presented)

Dependencies

bi-api: feature/BI-1618

Testing

Import files into Germplasm, Ontology, and Experiments. One file for each type of error:

  1. Improperly formatted (ex. missing expected columns)
  2. Missing required data elements
  3. Other errors

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@davedrp davedrp requested review from a team, dmeidlin and nickpalladino and removed request for a team June 12, 2023 19:43
@davedrp davedrp changed the title Feature/bi 1618 Feature/bi 1618 - Import File Selection Behavior Jun 12, 2023
@davedrp davedrp marked this pull request as ready for review June 12, 2023 23:36
Copy link
Member

@nickpalladino nickpalladino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing I noticed in testing was that when an upload fails and you choose a new file the filename will be highlighted red like it is erroneous rather than black for the normal case. Not really a big deal to me so I'll approve either way.

@davedrp davedrp merged commit 6acad34 into develop Jun 30, 2023
@davedrp davedrp deleted the feature/BI-1618 branch June 30, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants