Skip to content

BI-1651 - Allow programs to choose/create breeding methods#292

Merged
timparsons merged 5 commits intodevelopfrom
feature/BI-1651
Jan 27, 2023
Merged

BI-1651 - Allow programs to choose/create breeding methods#292
timparsons merged 5 commits intodevelopfrom
feature/BI-1651

Conversation

@timparsons
Copy link
Member

@timparsons timparsons commented Jan 9, 2023

Description

Story: https://breedinginsight.atlassian.net/browse/BI-1651

Created a new interface under program administration to allow a breeding program to control what system breeding methods are allowed, and to create/edit/delete their own custom breeding methods.

Dependencies

bi-api/feature/BI-1651

Testing

  1. Verify that only the breeder role can see the Breeding Method configuration screen
  2. Verify that when first creating a program, and then navigating to the Breeding Method config screen, that all of the system breeding methods are visible
  3. Verify that system breeding methods can be enabled/disabled
  4. Verify that a new breeding method can be created, and that it only shows up for the program it was created in
  5. Verify that germplasm can be created with program defined breeding methods
  6. Verify that germplasm cannot be created with system breeding methods not enabled by the program
  7. Verify that a program breeding method cannot be deleted if there is a germplasm record utilizing that method
  8. Verify that a system breeding method cannot be disabled if there is a germplasm record utilizing that method

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: https://github.com/Breeding-Insight/taf/actions/runs/3887368051

@davedrp
Copy link
Contributor

davedrp commented Jan 23, 2023

Passed all test in the Acceptance Criteria.

Also added ability for programs to enable/disable breeding methods defined at the system level
- Implementing custom search for breeding methods tables
- Implementing restricting editing for methods used by germplasm records
@timparsons timparsons merged commit 2c60ca1 into develop Jan 27, 2023
@timparsons timparsons deleted the feature/BI-1651 branch January 27, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants