[BI-1615] - Add termType to Trait DB Table#285
Merged
nickpalladino merged 4 commits intodevelopfrom Jan 18, 2023
Merged
Conversation
This was referenced Dec 5, 2022
davedrp
approved these changes
Dec 14, 2022
dmeidlin
requested changes
Dec 14, 2022
Contributor
dmeidlin
left a comment
There was a problem hiding this comment.
All features work as expected. The "Term Type" field in both the edit and new ont. term forms has an asterisk (denoting required field) and is listed at the top above the Name and Description fields. While the frontend and backend checks should stay in place, the asterisk is superfluous and should be removed since the dropdown prevents inputing unsupported or null values. Also, the Term Type field should be below the Description field and above the synonym field to be more consistent with the order of the fields in the details summary and table column headings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-1615 - Add termType to Trait DB Table
NOTE: This is forked from BI-1614, so changelist will include changes from there until BI-1614 is merged into develop
Small improvements off BI-1614 to ensure term types actually display
Created EnumUtils to handle methods for converting between enum key and value for ease of converting between the user-friendly display value and the backend storage value, and utilized them for term types
NOTE: Sorting could get weird if the alphabetical order differs between the user friendly display (ie Germplasm Passport) and backend storage value (GERM_PASSPORT). Not a problem here, but something to keep in mind. Also the difference between display and backend and the fact that there are a few distinct types means that if filtering was to be implemented for term types in the future it should probably be via drop down rather than text box.
Dependencies
bi-api/BI-1615
Testing
Checklist: