Conversation
7 tasks
davedrp
approved these changes
Nov 22, 2022
timparsons
requested changes
Nov 29, 2022
Comment on lines
+134
to
+135
| <p v-if="variable.startsWith('TS:')">{{ props.row.data.observations.filter(observation => observation.brAPIObject.observationVariableName === variable.replace(/TS:\s*/,""))[0].brAPIObject.observationTimeStamp}}</p> | ||
| <p v-else>{{ props.row.data.observations.filter(observation => observation.brAPIObject.observationVariableName === variable)[0].brAPIObject.value }}</p> |
Member
There was a problem hiding this comment.
I'd suggest making functions to handle fetching the timestamp and value instead of doing it in line here
Contributor
Author
There was a problem hiding this comment.
Added a function to handle it instead, seems to work from my quick testing.
timparsons
approved these changes
Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-1194 - Upload with timestamps
Updates to enable display of timestamp values in experiment import preview and to ensure that dynamic columns (phenotypes and timestamps) are displayed in the same order as in the import file.
Dependencies
bi-api/BI-1194
Testing
Import experiment file with phenotypes and timestamps of both date and date/time values (the latter indicated by TS: ontology term name)
Ensure preview screen displays phenotype and timestamp columns and values in same order as file
Ensure timestamp columns with date only in file also have time of midnight associated in preview
Import experiment file with incorrect timestamp format - error should display
Import experiment file with timestamp that doesn't correspond to a phenotype column in the file - error should display
Checklist: