Skip to content

[BI-1473] - Append existing germplasm with optional details#265

Merged
nickpalladino merged 8 commits intodevelopfrom
feature/BI-1473
Apr 19, 2023
Merged

[BI-1473] - Append existing germplasm with optional details#265
nickpalladino merged 8 commits intodevelopfrom
feature/BI-1473

Conversation

@HMS17
Copy link
Contributor

@HMS17 HMS17 commented Sep 14, 2022

Description

Story: BI-1473 - Allow user to append existing germplasm with optional details

A new card was created to reduce the scope of this one: https://breedinginsight.atlassian.net/browse/BI-1735?atlOrigin=eyJpIjoiYzJmNjgzZjU1YjBlNGNlNzk4YTFiYzVjZGU2YzA1NDkiLCJwIjoiaiJ9

Dependencies

bi-api/BI-1473

Testing

  • Import new germplasm and verify works as before with no regressions
  • Update a germplasm synonyms
  • Update a germplasm with no existing pedigree to create a pedigree
  • Try to update a germplasm with existing pedigree with new pedigree and verify that an error occurs and doe not allow it
  • Update synonyms to germplasm with existing synonyms and verify that they are added to the list if no already existing
  • Add existing germplasm to new germplasm list without updating pedigree or synonyms
  • Add existing germplasm to new list and verify that pedigree and synonyms are as expected

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>

@nickpalladino nickpalladino marked this pull request as ready for review March 28, 2023 20:26
@nickpalladino nickpalladino requested review from a team, davedrp, nickpalladino and timparsons and removed request for a team and nickpalladino March 28, 2023 21:02
Copy link
Member

@timparsons timparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving assuming you'll run TAF

@nickpalladino nickpalladino merged commit 46b3a61 into develop Apr 19, 2023
@nickpalladino nickpalladino deleted the feature/BI-1473 branch April 19, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants