[BI-1445] - Trait Entity/Attribute/Method capitalization#240
Merged
HMS17 merged 4 commits intorelease/0.6from Jun 15, 2022
Merged
[BI-1445] - Trait Entity/Attribute/Method capitalization#240HMS17 merged 4 commits intorelease/0.6from
HMS17 merged 4 commits intorelease/0.6from
Conversation
7 tasks
ctucker3
suggested changes
Jun 14, 2022
| try { | ||
| const response = await TraitService.getAttributesEntitiesDescriptions(this.activeProgram!.id!); | ||
| //Want to retrieve all entries for autocomplete not just those on current page | ||
| //TODO: right now this.traitsPagination.totalCount is 0 when it hits this method, so relying on large number to retrieve all values |
Contributor
There was a problem hiding this comment.
If you await the call to this.getTraits would that give you a this.traitsPagination.totalCount here? It might be worth implementing that now since its a small change.
ctucker3
approved these changes
Jun 15, 2022
davedrp
approved these changes
Jun 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-1445 - Trait Column value not the same as entered in the the Term creation
Implemented changes to make capitalization of trait entity, trait attribute, and method description more consistent in table and sidepanel display.
For display in table and details panel, the first letter of each word for the trait entity, trait attribute, and method description will be capitalized
For trait attribute and method description the rest of the capitalization will match what the user entered, and on edit the user will see the capitalization as they entered it.
For trait entity, due to it being a set and therefore having to have consistent case, regardless of user entry for capitalization the first letter of each word will always be capitalized and the rest of the letters will be lowercase in both display and in edit.
Dependencies
bi-api/BI-1445
Testing
Checklist: