Conversation
…into feature/BI-1339 � Conflicts: � src/router/index.ts
| config.method = 'get'; | ||
| config.programId = programId; | ||
| config.germplasmId = germplasmId; | ||
| config.params = {}; //todo check if needed |
| reject(error); | ||
| }) | ||
| } else { | ||
| reject(); |
There was a problem hiding this comment.
Might be good to have a rejection reason in case we ever need to debug this.
| <router-link v-bind:to="{name: 'germplasm-all', params: {programId: activeProgram.id}}"> | ||
| All Germplasm | ||
| </router-link> | ||
| <p></p> |
There was a problem hiding this comment.
Maybe a class of mb-4 instead of the empty <p></p> on the router-link if you're going for spacing?
| }).catch((error) => { | ||
| // Display error that germplasm cannot be loaded | ||
| this.$emit('show-error-notification', 'Error while trying to load germplasm'); | ||
| throw error; |
There was a problem hiding this comment.
I think throwing this error here will make it so you never get to the finally to be able to turn off the germplasmLoading. Have you tried that out?
There was a problem hiding this comment.
Tested it and yeah it gets to finally.
| return dateTime.format("DD/MM/YYYY"); | ||
| } | ||
| return ""; | ||
| } |
There was a problem hiding this comment.
Could be useful on Germplasm model.
| getGermplasmUUID(references: ExternalReferences){ | ||
| let val = references.find(ref => ref.referenceSource === process.env.VUE_APP_BI_REFERENCE_SOURCE); | ||
| return val ? val.referenceID : ""; | ||
| } |
There was a problem hiding this comment.
Could be useful on Germplasm model.
timparsons
left a comment
There was a problem hiding this comment.
Need to run the code still, but one suggested change
.env.development
Outdated
| VUE_APP_LOG_LEVEL=${WEB_LOG_LEVEL} | ||
|
|
||
| # The reference source | ||
| VUE_APP_BI_REFERENCE_SOURCE=breeding-insight.org |
There was a problem hiding this comment.
can this be changed to breedinginsight.org
Description
Story: BI-1339 - Germplasm Details page
Updates to enable display of individual germplasm details
Dependencies
bi-api/feature/BI-1339
Testing
Checklist: