Skip to content

BI-2656 - Append with Prior Observations Blank Edge Case#485

Merged
mlm483 merged 1 commit intorelease/1.1.1from
bug/BI-2656-qa
Aug 13, 2025
Merged

BI-2656 - Append with Prior Observations Blank Edge Case#485
mlm483 merged 1 commit intorelease/1.1.1from
bug/BI-2656-qa

Conversation

@mlm483
Copy link
Contributor

@mlm483 mlm483 commented Aug 12, 2025

Description

Story: BI-2656

This fixes a bug discovered in QA while testing BI-2656.

Testing

Optionally run through this procedure on release/1.1.1 first to reproduce the bug.

  1. Upload germplasm, ontology and this experiment with two observation units and one observation value plus timestamp.
  2. Download the experiment, and edit the file.
    • Row 1: Delete the observation value and timestamp (make those cells blank).
    • Row 2: Add a new observation value and timestamp.
    • Save file.
  3. Upload the edited file using the "Append" workflow.
    • Ensure the preview shows the correct statistics and does not indicate that data is being overwritten.
    • Ensure the upload completes successfully on confirm.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

handles append use case when prior data is left blank
@github-actions github-actions bot added the bug Something isn't working label Aug 12, 2025
@mlm483 mlm483 changed the title BI-2656 - Append workflow requires timestamps BI-2656 - Append with Prior Observations Blank Edge Case Aug 12, 2025
Copy link
Contributor

@davedrp davedrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passed test. code looks good.

@mlm483 mlm483 merged commit 64c0cf8 into release/1.1.1 Aug 13, 2025
2 checks passed
@mlm483 mlm483 deleted the bug/BI-2656-qa branch August 13, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants