Description

Story: https://breedinginsight.atlassian.net/browse/BI-2656

Changes:

• Added a null check in OverwrittenData.
• Added a parameter to ImportTableProcess::isChanged to distinguish between the case when a timestamp column in present in the uploaded file but the value is null and when the timestamp column is absent from the file.
• Added an integration test to cover this edge case.

Dependencies

bi-web branch: release/1.1.1

Testing

Set Up

• Upload germplasm, ontology, and experiment.

Test Procedure

Optionally test the following with the release/1.1.1 branch of bi-api first to repoduce the bug.

• Download the KRSP22-j experiment without timestamps.
• Open the file and add a phenotypic data column, for example INCW8SUM.
• Save and upload the file using the append workflow.
  • If using release/1.1.1 this will result in an error.
  • If using bug/BI-2656-release this will succeed.
    • Ensure that there is no overwrite warning (pictured below) after upload.

Checklist:

• I have performed a self-review of my own code
• I have tested my code and ensured it meets the acceptance criteria of the story
• I have tested that my code works with both the brapi-java-server and BreedBase
• I have create/modified unit tests to cover this change
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to documentation
• I have run TAF: <please include a link to TAF run>