Skip to content

BI-2639 - List referencing existing germplasm - very slow and impacting jobs timer#472

Merged
nickpalladino merged 3 commits intorelease/1.1.1from
bug/BI-2639
Jun 17, 2025
Merged

BI-2639 - List referencing existing germplasm - very slow and impacting jobs timer#472
nickpalladino merged 3 commits intorelease/1.1.1from
bug/BI-2639

Conversation

@nickpalladino
Copy link
Member

@nickpalladino nickpalladino commented Jun 12, 2025

Description

Story: BI-2639

  • Only make PUT calls when germplasm are actually mutated
  • Update pedigree connection count so it's correct for update case

Dependencies

  • release/1.1.1 bi-web and brapi-server

Testing

  • See JIRA card for acceptance criteria test cases

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@nickpalladino nickpalladino changed the base branch from develop to release/1.1.1 June 12, 2025 20:32
@nickpalladino nickpalladino marked this pull request as ready for review June 13, 2025 19:13
@nickpalladino nickpalladino requested review from HMS17 and davedrp June 13, 2025 19:14
@HMS17 HMS17 self-assigned this Jun 16, 2025
Copy link
Contributor

@HMS17 HMS17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with smaller files to focus on counts in acceptance criteria, most of which passed.

In all cases, job statistics show <number of new germplasm + number of pedigree connections added> for total and completed counts. This confirms that synonyms are not counted in job statistics, clarifying the discussed difference in acceptance criteria, but also conflicts with the acceptance criteria which seems to assume that the total and completed counts should be <number of new germplasm + number of existing germplasm with changed pedigrees> in the case of a file with existing and new germplasm and pedigree changes or 0 in the case that the file only consists of existing germplasm with pedigree changes. Could you clarify which is the expected behavior?

@nickpalladino
Copy link
Member Author

Tested locally with smaller files to focus on counts in acceptance criteria, most of which passed.

In all cases, job statistics show <number of new germplasm + number of pedigree connections added> for total and completed counts. This confirms that synonyms are not counted in job statistics, clarifying the discussed difference in acceptance criteria, but also conflicts with the acceptance criteria which seems to assume that the total and completed counts should be <number of new germplasm + number of existing germplasm with changed pedigrees> in the case of a file with existing and new germplasm and pedigree changes or 0 in the case that the file only consists of existing germplasm with pedigree changes. Could you clarify which is the expected behavior?

Thanks! Updated acceptance criteria to be X rather than 0 for first and germplasm + pedigree connections for last.

@HMS17 HMS17 self-requested a review June 17, 2025 15:32
Copy link
Contributor

@HMS17 HMS17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acceptance criteria matches local testing, approved!

@nickpalladino nickpalladino merged commit 1ad3176 into release/1.1.1 Jun 17, 2025
1 check passed
@nickpalladino nickpalladino deleted the bug/BI-2639 branch June 17, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants