[BI-2632] Germplasm download from single list no longer working#463
Merged
[BI-2632] Germplasm download from single list no longer working#463
Conversation
mlm483
approved these changes
May 9, 2025
dmeidlin
requested changes
May 9, 2025
Contributor
dmeidlin
left a comment
There was a problem hiding this comment.
The export works as expected, but there aren't any tests to cover the endpoint in GermplasmControllerIntegrationTest, and it should really be added. You can see how the @ParameterizedTest annotation was used in ExperimentControllerIntegrationTest to reuse the same test for different requested file formats for the export.
Contributor
Author
|
The two unit test that are failing (UserControllerIntegrationTest & MetadataFilterIntegrationTest) are known issues, and not related this this story. |
nickpalladino
approved these changes
Jun 2, 2025
dmeidlin
approved these changes
Jun 6, 2025
…stDbId}/export{?fileExtension}") endpoint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BI-2632 Germplasm download from single list no longer working
Description
Attempting to download a Germplasm List results in a 403 error.
Please include a summary of the change that was made.
The endpoint @get("/programs/{programId}/germplasm/lists/{listDbId}/export{?fileExtension}") was removed, but is still being called. The endpoint was restored.
Dependencies
bi-web: release/1.1
Testing
Please include any details needed for reviewers to test this code
EXPECTED RESULT
File downloads successfully.
Checklist: